Skip to content

gh-92525: make inspect.getfile PEP 420 compliant #92635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
carlbordum wants to merge 3 commits into
base: main
Choose a base branch
from
Open

gh-92525: make inspect.getfile PEP 420 compliant #92635

carlbordum wants to merge 3 commits into from

Conversation

@carlbordum
Copy link
Contributor

@carlbordum carlbordum commented May 10, 2022 •
edited by bedevere-bot
Loading

serhiy-storchaka
serhiy-storchaka requested changes May 11, 2022
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test and a NEWS entry.

@bedevere-bot
Copy link

bedevere-bot commented May 11, 2022

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@carlbordum carlbordum force-pushed the 92525-inspect-getfile-pop-420 branch from 0efd3c7 to 89b2b45 Compare May 11, 2022 15:54
@carlbordum
Copy link
Contributor Author

carlbordum commented May 11, 2022

I have made the requested changes; please review again

@bedevere-bot
Copy link

bedevere-bot commented May 11, 2022

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

serhiy-storchaka
serhiy-storchaka reviewed May 11, 2022
View reviewed changes
@carlbordum carlbordum force-pushed the 92525-inspect-getfile-pop-420 branch from 89b2b45 to 0b4953e Compare May 21, 2022 19:07
@carlbordum carlbordum force-pushed the 92525-inspect-getfile-pop-420 branch 2 times, most recently from e8c07a1 to d6b227d Compare September 1, 2022 18:48
@carlbordum carlbordum force-pushed the 92525-inspect-getfile-pop-420 branch from d6b227d to 9aaf28c Compare September 1, 2022 19:39
@carlbordum
Copy link
Contributor Author

carlbordum commented Sep 1, 2022

What do you think of this? Should something more be tested?

@bedevere-app bedevere-app bot mentioned this pull request Dec 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka requested changes

Assignees

No one assigned

Labels

awaiting change review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carlbordum @bedevere-bot @serhiy-storchaka